Allow adding test cases testing version-dependent Python features#9238
Merged
JelleZijlstra merged 2 commits intomainfrom Nov 21, 2022
Merged
Allow adding test cases testing version-dependent Python features#9238JelleZijlstra merged 2 commits intomainfrom
JelleZijlstra merged 2 commits intomainfrom
Conversation
AlexWaygood
commented
Nov 21, 2022
sobolevn
approved these changes
Nov 21, 2022
Member
sobolevn
left a comment
There was a problem hiding this comment.
This looks like a good work-around!
Ideally we can teach mypy not to trigger unused ignore on unreachable code as well.
Thanks!
JelleZijlstra
approved these changes
Nov 21, 2022
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
I suppose this won't work if we want test cases for things that were removed in a later version, but we'll have to figure out an approach for that when we get to it.
Member
Author
Here's hoping nobody proposes to add test cases for things that have already been deprecated and removed in released versions of Python :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently impossible to add a test case for
ExceptionGrouporBaseExceptionGroup: see #9230. You'd think that you'd be able to just put the test behind anif sys.version_info >= (3, 11)guard, and pyright is indeed fine with that. Mypy, however, is not: when you run the test case with--python-version 3.10, it complains about many "unused type ignore" comments (it detects thetype: ignorecomments behind theif sys.version_info >= (3, 11)guard, even though it considers the whole block unreachable with--python-version 3.10, meaning it considers alltype: ignores within that block to be "unused").This PR works around that mypy annoyance. If this PR is merged, the test-case file can simply be renamed to be
test_cases/stdlib/builtins/check_exception_group-py311.py, andpython tests/regr_test.py --allshould pass.Cc. @sobolevn