Deprecate PurePath.as_uri
#15178
Open
Deprecate PurePath.as_uri
#15178
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: trio (https://github.com/python-trio/trio)
+ src/trio/_path.py:267: error: Argument 1 to "as_uri" of "Path" has incompatible type "trio._path.Path"; expected "pathlib.Path" [arg-type]
|
donbarbos
reviewed
Dec 26, 2025
Contributor
donbarbos
left a comment
donbarbos
left a comment
There was a problem hiding this comment.
Thank you!
PR: python/cpython#127380
Comment on lines
+93
to
94
| @deprecated("PurePath.as_uri() is deprecated. Use Path.as_uri() instead.") | ||
| def as_uri(self) -> str: ... |
Contributor
There was a problem hiding this comment.
It seems like a version check wouldn't hurt here.
Suggested change
| @deprecated("PurePath.as_uri() is deprecated. Use Path.as_uri() instead.") | |
| def as_uri(self) -> str: ... | |
| if sys.version_info >= (3, 14): | |
| @deprecated("Deprecated since Python 3.14; will be removed in Python 3.19. Use `Path.as_uri()` instead.") | |
| def as_uri(self) -> str: ... | |
| else: | |
| def as_uri(self) -> str: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in favor of
Path.as_urias of 3.14.