Skip to content

Conversation

@max-muoto
Copy link
Contributor

This PR adds the 3.14 deprecation of prefix_chars to add_argument_group

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Contributor

@donbarbos donbarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
PR: python/cpython#125563

conflict_handler: str = ...,
) -> _ArgumentGroup: ...
@overload
@deprecated("Passing 'prefix_chars' to add_argument_group() is deprecated")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use more unify deprecation message:

Suggested change
@deprecated("Passing 'prefix_chars' to add_argument_group() is deprecated")
@deprecated("The `prefix_chars` parameter deprecated since Python 3.14.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants