Skip to content

PEP 467: Fix footnotes #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 2 commits into from
Aug 17, 2022
Merged

PEP 467: Fix footnotes #2752

hugovk merged 2 commits into from
Aug 17, 2022

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Aug 7, 2022 •
edited
Loading

Fix these warnings:

pep-0467.txt:239: WARNING: Footnote [1] is not referenced.
pep-0467.txt:241: WARNING: Footnote [2] is not referenced.
pep-0467.txt:243: WARNING: Footnote [3] is not referenced.
pep-0467.txt:245: WARNING: Footnote [4] is not referenced.
pep-0467.txt:247: WARNING: Footnote [5] is not referenced.
pep-0467.txt:249: WARNING: Footnote [6] is not referenced.

They're not really footnotes, so like in #2644 and others, let's convert them to regular links.

Plus update a couple of redirects.

Preview

https://pep-previews--2752.org.readthedocs.build/pep-0467/

@hugovk hugovk added the bug label Aug 7, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk !

@hugovk hugovk merged commit cdc1a44 into python:main Aug 17, 2022
@hugovk hugovk deleted the pep467-fix-footnotes branch August 17, 2022 05:26
@hugovk hugovk mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @CAM-Gerlach