Style: Scroll code blocks instead of wrapping them #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Mar 23, 2022
Member
Author
|
As this is a straightforward fix, its been 24 hours and it seems all involved have 👍 ed it, I'll go ahead and merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @encukou and confirmed by @hugovk in #2439 , the current approach of wrapping code/literal blocks at narrow viewport widths makes them difficult to read, especially if they are particularly wide, include multiple columns of text, and are not correct syntax-highlighted, all of which is the case for, e.g., at least one example block in PEP 678.
A better approach, as discussed there, is to simply allow scrolling overly-wide code blocks instead of wrapping them, which is what GitHub and other sites do (as well as most editors by default, if soft-wrap is not enabled). This PR implements that approach, resolving the issue.
Before and after on a simulated iPhone SE (2nd gen), a particularly narrow device: