PEP 675: Clarify wording in various sections #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already a Backwards Compatibility heading for Type Inference. So, I just inlined the second one into the Runtime Behavior section.
CAM-Gerlach
requested changes
Jan 26, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Excellent job on the writing, @pradeep90 . I just had a few rst/PEP syntax and formatting comments.
We had two "sections" - one for the type inference and one for the runtime behavior. Move them both into one top-level section.
CAM-Gerlach
approved these changes
Jan 26, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM, thanks @pradeep90 ! I'll let @JelleZijlstra review and merge, being the PEP sponsor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just nits.
Remaining: Add an exhaustive list of
strmethods that we will modify. I'm making that a separate PR for ease of review.cc @gbleaney