Skip to content

Conversation

@AA-Turner
Copy link
Member

I'll regret this!
A

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AA-Turner AA-Turner changed the title Add myself as the default reviewer for infrastructure stuff Add Adam Turner as the default reviewer for PEP infrastructure Jan 20, 2022
@AA-Turner AA-Turner merged commit c0ea0a9 into python:main Jan 20, 2022
@AA-Turner AA-Turner deleted the codeowners-infra branch January 20, 2022 05:49
@AA-Turner
Copy link
Member Author

First PR merged, too! 🎉

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Jan 20, 2022

Great! A few other things you might want to consider also claiming, in case you haven't already:

  • /docs (co-claim with me, if desired; at least until we decide what to do with them)
  • /.github/workflows (I can co-claim as well)
  • Makefile (since your work has considerable effect on this)
  • requirements.txt (you'll likely want to know when deps are changed)

I will propose to claim .pre-commit-config.yml, since I wrote most of it in its current form (along with Hugo) and I'm pretty intimately familiar with pre-commit.

@AA-Turner
Copy link
Member Author

Done apart from /docs (in case we remove all docs, don't want needless churn)
A

@CAM-Gerlach
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants