PEP 636: clarify __match_args__ naming #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current example allows the reader to wonder whether the __match_args__ names must match the __init__ args or the class members. This change explicitly shows that class member names are searched for the __match_args__ items (admittedly at the cost of some clutter).
gvanrossum
reviewed
Nov 7, 2021
Thx Guido, that reduces the clutter. Co-authored-by: Guido van Rossum <[email protected]>
gvanrossum
reviewed
Nov 8, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Fix the next two lines too please :-)
gvanrossum
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example allows the reader to wonder whether the match_args names must match the init args or the class members. This change explicitly shows that class member names are searched for the match_args items (admittedly at the cost of some clutter).