Skip to content

Conversation

@iritkatriel
Copy link
Member

No description provided.

pep-0654.rst Outdated
Comment on lines 328 to 329
+------------------------------------
+------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two "outdents" seem superfluous.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have only one? Or no closing line at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should only be one, and it should be indented with the entry immediately above it.

pep-0654.rst Outdated
Comment on lines 328 to 329
+------------------------------------
+------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should only be one, and it should be indented with the entry immediately above it.

pep-0654.rst Outdated
| Traceback (most recent call last):
| File "<stdin>", line 4, in <module>
| ValueError: bad value
+------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be aligned with what's above it? (Also in a few other places.)

There's also a redundant extra line of dashes above on line 794 (GitHub won't let me comment there).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so too, I probably misunderstood what you meant earlier. Online 802, it should be indented 4 more places so the + is under the |, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants