[clean strict optional] Fix another 32 errors#3265
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Apr 27, 2017
Merged
[clean strict optional] Fix another 32 errors#3265ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi merged 2 commits intopython:masterfrom
Conversation
Collaborator
|
I've noticed the |
JukkaL
approved these changes
Apr 27, 2017
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for helping us move towards strict optional! Feel to merge as is, or fix the Instance.type issue first.
Member
Author
|
I think it will be easier to merge this now and make a dedicated PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans
--strict-optionalfor:There are still 2 errors in the last one, but one of them is a typeshed issue (will report it tomorrow), and another should be fixed when @elazarg will finish #1855.
There is something interesting that I have noticed: there are around 150 errors only because
Instance.typehas typeOptional[TypeInfo]. However, it could beNoneonly right after de-serialization. It seems that these 150 errors could be fixed either by tweaking de-serialization (use a temporary classNotReadyInstance?) or just add "semi-automatically" some 150 asserts.