Fix incompatible overrides of overloaded methods in concrete subclasses by hauntsaninja · Pull Request #14017 · python/mypy

hauntsaninja · 2022-11-05T22:32:27Z

JelleZijlstra · 2022-11-05T22:41:01Z

mypy/checker.py

+                        for item in original_type.items
+                        if not item.arg_types or is_subtype(active_self_type, item.arg_types[0])
+                    ]
+                    if filtered_items:


If there are no filtered_items, shouldn't we always treat the override as compatible? e.g. in your F test below, I think the override is actually compatible: the base class says nothing about what the method should return if self is an A[bytes].

Yeah, I wasn't sure about this, but it seemed like a weird situation so I chose to fail. Feels sketchy to introduce a Callable[..., Any] ... I'll add a comment and if it ever comes up we can reconsider

hauntsaninja · 2022-11-05T23:23:37Z

I think the mypy_primer hits are from a different bug, will fix in another PR

Discovered as part of python#14017

Discovered as part of #14017

hauntsaninja · 2022-11-06T02:56:07Z

Hmm, there are still some issues involving type variables:

from typing import overload, TypeVar, Union

ZAT = TypeVar("ZAT", bound="ZA")

class ZA:
    @overload
    def f(self: ZAT, x: int) -> ZAT: ...
    @overload
    def f(self, x: str) -> None: ...
    @overload
    def f(self: ZAT) -> bytes: ...
    def f(*a, **kw): ...

class ZB(ZA):
    @overload
    def f(self, x: int) -> ZB: ...
    @overload
    def f(self, x: str) -> None: ...
    def f(*a, **kw): ...

^this correctly gives an error on master, but this PR removes the error.

Given that this fixes a real issue I might add an xfail test and merge anyway, but let me see if I can figure out a change to make this work as well

hauntsaninja · 2022-11-06T03:13:58Z

Okay I added the xfail test. The correct solution probably involves the bind_self code. I think some of the pandas errors might come back once it's fixed too

github-actions · 2022-11-06T03:46:46Z

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ pandas-stubs/core/series.pyi:1752: error: Unused "type: ignore" comment

pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/series.py:3380: error: Unused "type: ignore" comment
+ pandas/core/series.py:5132: error: Unused "type: ignore" comment
+ pandas/core/frame.py:5531: error: Unused "type: ignore" comment

hauntsaninja · 2022-11-10T23:31:36Z

Let me know if you think the new false negative is not acceptable

JelleZijlstra

The xfail case seems fairly contrived and false negatives are better than false positives, so I think this is an improvement. Thanks!

Fixes python#14866 Basically does the potential todo I'd mentioned in python#14017

…4882) Fixes #14866 Basically does the potential todo I'd mentioned in #14017

Fixes python#15041 Related to python#14882 and python#14017

Fixes #15041 Related to #14882 and #14017 (the older one is where I added the xfail test)

hauntsaninja mentioned this pull request Nov 5, 2022

typing: accept buffers in typing.IO.write python/typeshed#9084

Closed

Fix incompatible overrides of overloaded methods in concrete subclasses

5c90d1e

Fixes python#14002

hauntsaninja force-pushed the generic-self branch from d986d87 to 5c90d1e Compare November 5, 2022 22:34

JelleZijlstra reviewed Nov 5, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

more tests

d62b1c7

failing self test

8e575a5

hauntsaninja added a commit to hauntsaninja/mypy that referenced this pull request Nov 5, 2022

Fix bug in overload compatibility checking

41733c4

Discovered as part of python#14017

hauntsaninja mentioned this pull request Nov 5, 2022

Fix and optimise overload compatibility checking #14018

Merged

hauntsaninja added a commit that referenced this pull request Nov 6, 2022

Fix and optimise overload compatibility checking (#14018)

807da26

Discovered as part of #14017

hauntsaninja added 3 commits November 5, 2022 18:53

Merge remote-tracking branch 'origin/master' into generic-self

60a5d9f

add comment

992e252

more comment

7606d50

JelleZijlstra approved these changes Nov 6, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

add xfail test

635e575

hauntsaninja requested a review from JelleZijlstra November 10, 2022 23:31

JelleZijlstra approved these changes Nov 10, 2022

View reviewed changes

hauntsaninja merged commit a48dd5a into python:master Nov 10, 2022

hauntsaninja deleted the generic-self branch November 10, 2022 23:37

hauntsaninja added a commit to hauntsaninja/mypy that referenced this pull request Mar 11, 2023

Fix incompatible overrides of overloaded generics with self types

262e6e0

Fixes python#14866 Basically does the potential todo I'd mentioned in python#14017

hauntsaninja mentioned this pull request Mar 11, 2023

Fix incompatible overrides of overloaded generics with self types #14882

Merged

JelleZijlstra pushed a commit that referenced this pull request Mar 11, 2023

Fix incompatible overrides of overloaded generics with self types (#1…

e2e5d7f

…4882) Fixes #14866 Basically does the potential todo I'd mentioned in #14017

hauntsaninja added a commit to hauntsaninja/mypy that referenced this pull request Apr 13, 2023

Fix bounded self types in override incompatibility checking

0ac2f69

Fixes python#15041 Related to python#14882 and python#14017

hauntsaninja mentioned this pull request Apr 13, 2023

Fix bounded self types in override incompatibility checking #15045

Merged

tyralla mentioned this pull request Apr 14, 2023

Fix type argument inference for overloaded functions with explicit self types (Fixes #14943). #14975

Closed

hauntsaninja added a commit that referenced this pull request Apr 18, 2023

Fix bounded self types in override incompatibility checking (#15045)

3d9661c

Fixes #15041 Related to #14882 and #14017 (the older one is where I added the xfail test)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix incompatible overrides of overloaded methods in concrete subclasses#14017

Fix incompatible overrides of overloaded methods in concrete subclasses#14017
hauntsaninja merged 7 commits intopython:masterfrom
hauntsaninja:generic-self

hauntsaninja commented Nov 5, 2022

Uh oh!

JelleZijlstra Nov 5, 2022

Uh oh!

hauntsaninja Nov 5, 2022

Uh oh!

This comment has been minimized.

hauntsaninja commented Nov 5, 2022

Uh oh!

This comment has been minimized.

hauntsaninja commented Nov 6, 2022

Uh oh!

hauntsaninja commented Nov 6, 2022

Uh oh!

github-actions bot commented Nov 6, 2022

Uh oh!

hauntsaninja commented Nov 10, 2022

Uh oh!

JelleZijlstra left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hauntsaninja commented Nov 5, 2022

Uh oh!

JelleZijlstra Nov 5, 2022

Choose a reason for hiding this comment

Uh oh!

hauntsaninja Nov 5, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

hauntsaninja commented Nov 5, 2022

Uh oh!

This comment has been minimized.

hauntsaninja commented Nov 6, 2022

Uh oh!

hauntsaninja commented Nov 6, 2022

Uh oh!

github-actions bot commented Nov 6, 2022

Uh oh!

hauntsaninja commented Nov 10, 2022

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants