Conversation
| return site.getsitepackages() + [user_dir] | ||
| else: | ||
| from distutils.sysconfig import get_python_lib | ||
| from sysconfig import get_python_lib |
There was a problem hiding this comment.
I think this is only run on python 2 since getusersitepackages and getsitepackages were added in python 3.2, so it's probably fine to leave this using distutils.
There was a problem hiding this comment.
disutils is becoming a blocker for #11297. It makes sense to me to guard the python version here.
There was a problem hiding this comment.
I don't think guarding the python version is necessary because this code will never get run on python 3 anyways (although it probably wouldn't hurt either).
None of the DeprecationWarnings that I see in the CI run for #11297 seem to be because of this usage. All of those warnings seem to be either from mypyc/build.py or from the setup.py that mypyc generates.
There was a problem hiding this comment.
oh I thought it was causing error all over the codebase, my miss
There was a problem hiding this comment.
@pranavrajpal is correct. I already fixed this some time ago by moving the import from the top-level to the else-clause: #10203
There was a problem hiding this comment.
Yeah, agreed with pranavrajpal on not needing to change pyinfo.py. I think we still need the distutils API, but we'll want to get it from setuptools if possible. I opened #11306 for this.
|
Thanks for pointing out! I will fix rest erros directly in this PR #11297 |
5 participants
Description
Replaces
distutilswith other modules.Test Plan
Shouldn't affect any tests.