Fix a bunch of tests broken by python 3.10#10404
Merged
JukkaL merged 1 commit intopython:masterfrom May 4, 2021
Merged
Conversation
Python 3.10 changes a bunch of parser error messages. This commit introduces the version>= argument to [out] sections of tests, which allows testing against the new messages on newer python versions.
freundTech
changed the title
JukkaL
approved these changes
May 4, 2021
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks! This is a nice approach for dealing with differences between Python versions. Looks good.
21 tasks
JukkaL
pushed a commit
that referenced
this pull request
Dec 16, 2021
Followup to #11752. The syntax error changed between 3.10.0 and 3.10.1. https://bugs.python.org/issue46004 I missed a few the first time around unfortunately. https://bugs.python.org/issue46004 Instead of duplicating the original output, I chose to extend the test syntax introduced with #10404 and added support for == version checks.
JukkaL
pushed a commit
that referenced
this pull request
Dec 16, 2021
Followup to #11752. The syntax error changed between 3.10.0 and 3.10.1. https://bugs.python.org/issue46004 I missed a few the first time around unfortunately. https://bugs.python.org/issue46004 Instead of duplicating the original output, I chose to extend the test syntax introduced with #10404 and added support for == version checks.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Followup to python#11752. The syntax error changed between 3.10.0 and 3.10.1. https://bugs.python.org/issue46004 I missed a few the first time around unfortunately. https://bugs.python.org/issue46004 Instead of duplicating the original output, I chose to extend the test syntax introduced with python#10404 and added support for == version checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.10 changes a bunch of parser error messages. This commit introduces the version>= argument to [out] sections of tests, which allows testing against the new messages on newer python versions.
[out] sections are overwritten by other [out] sections following them.
I also thought about supporting other comparisons such as
<,==and others, while not having later out sections overwrite earlier out sections, but decided on this approach for simplicity.This was tested on
Python 3.10.0a7+ (heads/master:0cad068, Apr 30 2021, 14:45:23)(shortly before 3.10.0b1). Note that Travis CI nighly is still stuck on 3.10.0a5+.