Skip to content

gh-130664: specify how thousands separators are used with 0-padding #131030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirpichev wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-130664: specify how thousands separators are used with 0-padding #131030

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d26c426
gh-130664: specify how thousands separators are used with 0-padding
skirpichev Mar 10, 2025
3304ed2
Update Doc/library/string.rst
skirpichev Mar 10, 2025
4fbd177
Merge branch 'master' into fill-docs/130664
skirpichev Apr 6, 2025
6931a67
thousands separators -> digit group separators
skirpichev Apr 6, 2025
71dcf25
Update Doc/library/string.rst
skirpichev Apr 7, 2025
751d559
Merge branch 'master' into fill-docs/130664
skirpichev Aug 2, 2025
4aae176
address review: don't repeat description of digit group separator
skirpichev Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Doc/library/string.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,9 @@ If not specified, then the field width will be determined by the content.
When no explicit alignment is given, preceding the *width* field by a zero
(``'0'``) character enables sign-aware zero-padding for numeric types,
excluding :class:`complex`. This is equivalent to a *fill* character of
``'0'`` with an *alignment* type of ``'='``.
``'0'`` with an *alignment* type of ``'='``. If digit group separators of the
Copy link
Member

@picnixz picnixz Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that "digit group separator" is mentioned here while we only mention it in the "grouping option" paragraph below. Maybe we should mention it at that place or mention here that this will be introduced below?

Copy link
Member

@serhiy-storchaka serhiy-storchaka Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the different parts of the format are interconnected, there may be references to options described in details below.

But I think that we should unify wording and avoid repetition of what specifies the grouping option. "If the grouping option for the integral part is used, a digit group separator is also inserted between leading zeros."

Copy link
Contributor Author

@skirpichev skirpichev Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka, I think that remark was addressed. Is there anything left?

integral part of a number are used (as specified either by ``','`` or ``'_'``
option), they are also placed between leading zeros.

.. versionchanged:: 3.10
Preceding the *width* field by ``'0'`` no longer affects the default
Expand Down
Loading