Skip to content

gh-101260: Return to a simpler output buffer for zlib, bz2 and lzma for better performance. #101279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhpvorderman wants to merge 13 commits into from
Closed

gh-101260: Return to a simpler output buffer for zlib, bz2 and lzma for better performance. #101279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
78271bc
Remove blocksoutputbuffer
rhpvorderman Jan 23, 2023
f838c1d
Fix error regarding maximum length
rhpvorderman Jan 23, 2023
8793f1a
Add missing braces
rhpvorderman Jan 24, 2023
cf7c244
Set return value properly to NULL in case of error
rhpvorderman Jan 24, 2023
723ca68
Remove blocksbuffer from bz2module
rhpvorderman Jan 24, 2023
66199e4
Remove blocks output buffer
rhpvorderman Jan 24, 2023
852bae0
More consistent bracing style
rhpvorderman Jan 24, 2023
a1eff84
Grow bz2 buffer more aggresively
rhpvorderman Jan 24, 2023
b98450f
Start on lzma module
rhpvorderman Jan 24, 2023
6162715
Finish _lzmamodule
rhpvorderman Jan 24, 2023
38bef68
Code style changes
rhpvorderman Jan 24, 2023
52945c6
Add blurb
rhpvorderman Jan 24, 2023
b12be9b
Merge remote-tracking branch 'upstream/main' into gh-101260
rhpvorderman May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
317 changes: 0 additions & 317 deletions Include/internal/pycore_blocks_output_buffer.h
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Library/2023-01-24-10-20-52.gh-issue-101260.bsNSeT.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
In Python 3.10 a change was made that enhanced the performance of the zlib,
bz2 and lzma modules when operating on large (multiple megabytes) in-memory
buffers. However this came at the cost of a performance degradation for
smaller buffers. Since smaller buffers are used more often, particularly
during streaming, the change was reverted.
Loading