Skip to content

Conversation

@Conengmo
Copy link
Member

@Conengmo Conengmo commented May 17, 2023

Seems like a new pandas version got out that deprecated some things in three notebook. Let's see if everything runs okay now.

  • Altair 5.0.0 has a fix to work with the new Pandas version, so pin that.
  • New Altair version doesn't have data built in, use the vega_datasets package instead.
  • Some notebooks needed some syntax fixes to work with the new Pandas version.
  • Don't test the code of examples/WmsTimeDimension.ipynb, the external resource makes it flaky. We already skip it in the Selenium tests.

@Conengmo
Copy link
Member Author

There’s an issue with installing the packages on Python 3.7. Since that version will be end of line soon, I’ll upgrade the workflow to 3.8.

@Conengmo
Copy link
Member Author

Everything passes! 🚀

@Conengmo Conengmo merged commit 76647fe into python-visualization:main May 18, 2023
@Conengmo Conengmo deleted the repair-tests branch May 18, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant