Add TagFilterButton plugin #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jun 2, 2020
stickler-ci
reviewed
Jun 2, 2020
Contributor
Author
|
Added Examples and Tests. |
Conengmo
approved these changes
Nov 10, 2022
Member
There was a problem hiding this comment.
Good work! I updated the PR based on some improvements that came available later.
Link to example notebook: https://nbviewer.org/github/Waffleboy/folium/blob/tagfilterbutton/examples/TagFilterButton.ipynb
I removed the version for the plugin CDN link, so we'll always use the latest version.
I removed the onSelectionComplete argument, since this refers to a Javascript function. This might confuse our Python users. Power users can still pass this through the kwargs.
Let's merge this when the tests pass.
Conengmo
changed the title
Conengmo
added
ready
Member
|
Thank you @Waffleboy for your PR! Sorry it took so long to get processed. It will be included in the next folium release, 0.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very useful (and even basic) feature for interactive maps is dynamic filtering of points.
There's a plugin for leaflet called Tag Filter Button which does precisely that, add a button that will dynamically filter the maps based on a feature.
Demo available here
Link to plugin
I have built the plugin for folium,
sans the test and examples. If this is chosen to be added, I'll add them as wellEDIT: Tests and examples added as well.