This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Combine repeated response headers by concatenating their values with a comma separator #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a comma separator
Member
|
My reading of that section of the spec is that we need to delimit with null bytes, not commas: then we have to split on the other side. |
16 tasks
Member
|
At this stage the automated merge no longer works (the codebase has moved on quite far) and @alekstorm is sufficiently busy that I don't think he can own this patch. For now, I'll close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec isn't exactly inspiring in its clarity, but I'm pretty sure this section allows (or even requires?) this concatenation. Special handling for
set-cookie/cookiecan be added later, in theh2-10branch.