This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Fix integration test for Python 3#302
Merged
Lukasa merged 1 commit intopython-hyper:developmentfrom Jan 17, 2017
Merged
Conversation
Member
|
This looks good to me, thanks so much! ✨ |
Contributor
Author
|
BTW how to join the Hyper organization, created certain amount of PRs? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally this two tests
test_adapter_received_valuesandtest_adapter_sending_valueswould fail in Python 3 due toconnectionheader not being removed, which is a bug of theh2_safe_headersfunction.headers(class HTTPHeaderMap)stores bytes because we callto_bytestring_tuplewhen initiating it. While in Python 2bytesis equivalent tostr, andh2_safe_headerscan find'connection'successfully, in Python 3b'connection' != 'connection', so this header is not removed.Some affected tests are also modified.