Skip to content

Conversation

@shtlrs
Copy link
Member

@shtlrs shtlrs commented Jul 19, 2023

  • Bumps pydis_core to 10.1.0
  • Uses the utils already available in pydis_core instead of duplicating them here.

@shtlrs shtlrs added the review: do not merge The PR can be reviewed but cannot be merged now label Jul 19, 2023
@shtlrs shtlrs changed the title Bump to pydis core 10 Bump pydis_core to v10 Jul 19, 2023
@shtlrs shtlrs removed the review: do not merge The PR can be reviewed but cannot be merged now label Jul 20, 2023
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Now that bot-core can support multiple files, we should update the snekbox cog, in another PR, so that it uploads the text file outputs alongside all of the other outputs, rather than creating many pastefiles

@shtlrs shtlrs force-pushed the bump-to-pydis-core-10 branch from 0daba87 to 291e663 Compare July 25, 2023 10:53
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

@shtlrs shtlrs requested a review from wookie184 August 12, 2023 16:28
@shtlrs shtlrs force-pushed the bump-to-pydis-core-10 branch from 106c8eb to d388353 Compare August 26, 2023 09:38
@shtlrs shtlrs merged commit ec82d20 into main Aug 26, 2023
@shtlrs shtlrs deleted the bump-to-pydis-core-10 branch August 26, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants