Don't process comands until extensions are loaded #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChrisLovering
force-pushed
the
wait_until_bot_started
branch
2 times, most recently
from
487f04f to
b8bb6cf
Compare
ChrisLovering
changed the title
shtlrs
requested changes
Jul 25, 2023
Member
Author
Hah yea, my bad. Fixed in a fixup |
ChrisLovering
force-pushed
the
wait_until_bot_started
branch
from
b327ac0 to
ab03dbf
Compare
…s until all extensions are loaded.
ChrisLovering
force-pushed
the
wait_until_bot_started
branch
from
550e9be to
0213817
Compare
shtlrs
requested changes
Jul 25, 2023
shtlrs
approved these changes
Jul 25, 2023
Member
|
Thanks Chris ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BotBase.wait_until_bot_startedwhich can be used to hold a process until all extensions are loaded.This will also wait until all app commands have synced, if
sync_app_commandswas set when callingBotBase.load_extensions.I have also overwritten
discord.ext.commands.Bot.process_commandsto first callpydis_core.BotBase.wait_until_bot_startedto ensure no commands are processed until all extensions are loaded.