Simplify scoped loop fixture discovery#1112
Merged
seifertm merged 8 commits intopytest-dev:mainfrom May 9, 2025
Merged
Conversation
…rieve the name of the scoped event loop fixture.
… to retrieve the name of the scoped event loop fixture.
…or when there's no surrounding package or class.
…tests with function loop scope. This was needed for compatibility with the *event_loop* fixture which has since been removed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
- Coverage 90.14% 89.63% -0.52%
==========================================
Files 2 2
Lines 467 434 -33
Branches 60 53 -7
==========================================
- Hits 421 389 -32
Misses 30 30
+ Partials 16 15 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically, pytest-asyncio maintained one event loop fixture per pytest collector. This has changed in #1107 and pytest-asyncio only maintains one event loop per scope.
This PR removes obsolete management code related to having one loop per collector. In the process, this removes the restriction that a test marked with
asyncio(loop_scope="class")orasyncio(loop_scope="package")has to be surrounded by a class or test. The new behavior is in line with pytest's scope argument to fixtures.