Allow fixity, kind, role declarations in REPL#4046
Merged
JordanMartinez merged 1 commit intopurescript:masterfrom Jun 19, 2021
Merged
Allow fixity, kind, role declarations in REPL#4046JordanMartinez merged 1 commit intopurescript:masterfrom
JordanMartinez merged 1 commit intopurescript:masterfrom
Conversation
rhendric
force-pushed
the
rhendric/fix-3978
branch
from
a8cc5ca to
40c07e9
Compare
rhendric
force-pushed
the
rhendric/fix-3978
branch
from
40c07e9 to
764cfb4
Compare
It seems that advances in parsing and/or interpretation have made the artificial restriction that used to exist on declarations in the REPL no longer necessary. Fixity, kind, and role declarations are all tested and working, and the only other types of declarations that exist in the AST at this time are imports (which are specially handled in an earlier parser), BoundValueDeclarations (which can't be created at the top level), and binding groups (which are only created in desugaring).
rhendric
force-pushed
the
rhendric/fix-3978
branch
from
764cfb4 to
73950c8
Compare
Member
Author
|
Nudge nudge, this should be a pretty quick review for somebody. |
hdgarrood
approved these changes
Jun 19, 2021
JordanMartinez
approved these changes
Jun 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that advances in parsing and/or interpretation have made the
artificial restriction that used to exist on declarations in the REPL no
longer necessary. Fixity, kind, and role declarations are all tested and
working, and the only other types of declarations that exist in the AST
at this time are imports (which are specially handled in an earlier
parser), BoundValueDeclarations (which can't be created at the top
level), and binding groups (which are only created in desugaring).
Description of the change
Fixes #3978.
Checklist: