Erase elaborated kinds from all errors by default#4007
Merged
kl0tl merged 2 commits intopurescript:masterfrom Feb 17, 2021
Merged
Erase elaborated kinds from all errors by default#4007kl0tl merged 2 commits intopurescript:masterfrom
kl0tl merged 2 commits intopurescript:masterfrom
Conversation
natefaubion
approved these changes
Feb 6, 2021
hdgarrood
approved these changes
Feb 6, 2021
Contributor
|
Shall we merge the release notes PR first and then add this to the list of PRs for polykinds in the release notes then? |
Contributor
Sounds sensible to me. |
thomashoneyman
approved these changes
Feb 6, 2021
88bce0b to
0e7cc06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Nate noticed that
NoInstanceFounderrors were showing kind applications, which are supposed to be erased in error messages (not hints) unless with--verbose-errors, because they are directly rendered withtypeAtomAsBoxinstead of with something similar toprettyType.This pull request replaces all occurrences of
typeAtomAsBox prettyDepth, except in hints, with aprettyTypeAtomfunction which erase kind applications asprettyTypedoes.Checklist: