Remove spurious doc comment on CoreFn Module#3552
Merged
hdgarrood merged 2 commits intopurescript:masterfrom Sep 9, 2020
Merged
Remove spurious doc comment on CoreFn Module#3552hdgarrood merged 2 commits intopurescript:masterfrom
hdgarrood merged 2 commits intopurescript:masterfrom
Conversation
There have clearly been several changes since this comment was written, and this comment is now incorrect. Best to remove it.
Contributor
|
I'm not very familiar with this part of the compiler; can you explain why it's incorrect? |
Contributor
|
I think everything about the names is wrong, and this comment is definitely in the wrong place. I think it's important to document that we are not serializing types, but that should probably go in ToJSON/FromJSON. |
Member
|
There are no types in CoreFn to serialize. If that fact needs to be called out explicitly, here is as good a place as any, but then the comment would just be |
rhendric
approved these changes
Sep 2, 2020
hdgarrood
approved these changes
Sep 2, 2020
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Ok, that's good enough for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have clearly been several changes since this comment was written, and is now incorrect. Best to remove it.