Add helpers to go from Instants to a duration#99
Merged
garyb merged 3 commits intopurescript:masterfrom Jul 10, 2022
Merged
Conversation
Member
|
Looks good to me! Do we like the name |
Contributor
Author
|
@garyb I like duration much better. I wouldn't mind |
JordanMartinez
approved these changes
Jun 28, 2022
Contributor
JordanMartinez
left a comment
There was a problem hiding this comment.
I vote durationDelta
garyb
approved these changes
Jul 10, 2022
Member
|
Thanks, sorry about the wait! |
Member
|
Is this an equivalent implementation? (found it in the assorted datetime code I carry around my projects) import Data.DateTime as DateTime
import Data.DateTime.Instant as Instant
import Data.Time.Duration as Duration
diffInstant :: forall a. Duration.Duration a => Instant -> Instant -> a
diffInstant a b = DateTime.diff (Instant.toDateTime a) (Instant.toDateTime b) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #98
Checklist: