Skip to content

Conversation

@JordanMartinez
Copy link
Contributor

No description provided.

{ dependencies = [ "prelude" ]
, repo = "https://github.com/purescript/purescript-effect.git"
, version = "v2.0.1"
, version = "master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, but I'm wondering whether the original approach I was using to update the ecosystem should still be done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing it with prelude, I do now understand the intention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll use bower to update each core library and then use spago to verify that previous PRs made to core libraries still work on later PureScript rc releases. For example, prelude was updated when v0.14.0-rc2 was the release candidate. Harry made the -rc3 version now, so does prelude still compile on it? We could use spago and this branch to track that so we don't need to waste time updating each individual core library whenever a new release candidate is made.

@JordanMartinez JordanMartinez changed the title Include effect as updated lib Include multiple purescript org repos as updated libraries Oct 13, 2020
@JordanMartinez JordanMartinez merged commit 5b5cae6 into purescript:prepare-0.14 Oct 13, 2020
@JordanMartinez JordanMartinez deleted the updateEffect branch October 13, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants