Update CI: test if packages updated to 0.14 rc build without err/warn #716
Conversation
|
Alright. The CI for this branch now compiles packages listed in the One thing that would make this better is if CI failed when any warnings are emitted. Unfortunately, I'm not sure how that would be done. |
|
To make this build fail when warnings are emitted, I'll need to use Harry's compatibility update for |
There was a problem hiding this comment.
Looks great! 👏
I saw your thread on the Slack about having --strict fail the build if there are warnings in the dependencies. Something that could work for our usecase would be to have two Spago configs:
- one with the packages as dependencies and that we'd only use to call
spago install, so that we'd get the dependencies downloaded in the.spagofolder - once we do that we could move all the package sources to
src(so thatpsawould fail on warnings) - and then compile with
spago build -u "--strict"with another spago config with no dependencies
Would this work?
|
@f-f Thanks so much for the idea! Yes, it does work. I got so annoyed at this yesterday that I stopped working on it yesterday. The latest commit verifies that CI will fail when we compile packages that still have compiler warnings. I'll update |
If we forget to override the `metadata.version` field, CI will fail. Rather than doing this in two separate places for updatedLibs.dhall and usePsa.dhall, we do it once in shared.dhall.
2 participants
This updates the CI for the
prepare-0.14branch to test whether the packages listed insrc/spago.dhallcompile using the current release candidate of PureScript v0.14.0I'm not familiar with GitHub Actions yet, so I'm not sure whether this will work the first time. I also am not using Nix because I don't know how to configure it to use the release candidate.