Remove purescript-generics, upgrade dependencies#76
Conversation
|
|
src/CSS/ListStyle/Image.purs
Outdated
|
|
||
| instance showListStyleImage :: Show ListStyleImage where | ||
| show = gShow | ||
| show (ListStyleImage url) = "(ListStyleImage \"" <> url <> "\")" |
There was a problem hiding this comment.
Is it ok that I use quotes here?
There was a problem hiding this comment.
It's easier (and more correct) to do:
"(ListStyleImage " <> show url <> ")"
as that will use the proper escapes for everything inside the string.
There was a problem hiding this comment.
Thanks, I'll squash the commits
|
We're probably going to assimilate this PR into a 0.12 PR (which might need a few more tweaks and more version bumps). Thanks for starting the work 👍 |
vyorkin
force-pushed
the
feature/remove-generics
branch
from
2ad1b47 to
79ecea8
Compare
|
Would be nice to add |
|
@safareli sure, but I thought it is intended to be committed, according to official docs (for the reasons mentioned there) |
|
@safareli added 📦-lock.json to gitignore (but tbh I think it should be checked into VCS) |
vyorkin
force-pushed
the
feature/remove-generics
branch
from
03c0760 to
3b42db0
Compare
vyorkin
force-pushed
the
feature/remove-generics
branch
from
3b42db0 to
5c9ea29
Compare
|
Rebased onto the latest |
|
This looks good, thanks! |
4 participants
Should fix #73.
I had to manually implement
Showtype class in several cases