Skip to content

Do not simplify DivExpression if dividing with 0 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levno-710 merged 4 commits into from
Jun 29, 2022
Merged

Do not simplify DivExpression if dividing with 0 #66

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6796fd
Merge pull request #54 from levno-710/develop
levno-710 May 15, 2022
879f190
Merge pull request #57 from levno-710/develop
levno-710 May 18, 2022
384493d
Merge pull request #60 from levno-710/develop
levno-710 May 20, 2022
7318676
Do not simplify if dividing with 0
britzl Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/prometheus/ast.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ function Ast.MulExpression(lhs, rhs, simplify)
end

function Ast.DivExpression(lhs, rhs, simplify)
if(simplify and rhs.isConstant and lhs.isConstant) then
if(simplify and rhs.isConstant and lhs.isConstant and rhs.value ~= 0) then
local success, val = pcall(function() return lhs.value / rhs.value end);
if success then
return Ast.ConstantNode(val);
Expand Down