[SUGGESTION] Option to disable watermark

[wrefgtzweve]

Currently obfuscated code is shipped with the code below in front of it, I couldn't find a way to disable it through cli thus I'd like to suggest a cli option to disable this. It's not a big deal, but most other obfuscators allow you to disable a text like this.

--[[
    Obfuscated using Prometheus Alpha v0.2 by levno-710
]]

[king-ylac]

Why not just delete it yourself? It's not required.

[wrefgtzweve]

Yeah that's what I'm doing obviously. As described i in the issue, other obfuscators just have an option to disable it.

[britzl]

The source code comment states that "You are not allowed to edit the watermark". I don't quite understand the comment. The project is GPL licensed and can't prevent source code changes as long as the changes are in line with the license itself.

Furthermore it seems like a really bad idea to advertise which tool that was used to obfuscate a piece of code. Why give anyone trying to reverse engineer the code even the slightest clue as to which tool that was used?

My suggestion is to remove the watermark altogether.

[levno-710]

I am currently on vacation, so I cannot work on this, but I would be happy to accept a pull request, that removes the watermark

[wrefgtzweve]

Why was the watermark readded?

[levno-710]

Due to a feature request, although it is now another step, that can be disabled.
This can be acomplished by modifying presets.lua, or by creating a custom preset.
The watermark can also be set to custom text.

[wrefgtzweve]

I don't think a watermark should be in the default script config, plenty of points where brought up here why it shouldn't be.
And this remark makes me fearful of using this project at all.
#102 (comment)

[levno-710]

This is not so that the watermark cannot be changed by the user of prometheus, but rather by someone that will try to change the watermark after obfuscation.

This would only be a valid use case, if you wanted to steal the script and claim it as your own.

The watermark can still be changed or disabled by the script owner when using prometheus.

The watermark is mainly supposed to be used for custom watermarks, showing who the original author of a script was.

[wrefgtzweve]

Ah yeah that makes a lot more sense, i read it as it'd intentionally break code if it you where to remove the prometheus watermark. Thank you for your response. I appreciate that you removed it from the default presets! It's a cool feature but i feel like it indeed isn't something that should be on by default. Having it error when the watermark is removed sounds like a neat feature if used in the right usecase!