-
Notifications
You must be signed in to change notification settings - Fork 877
Add no notice support of Composite types #3025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for prisma2-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This PR changes the following pages (Netlify Preview Deploy links):
(Note that links will only be valid after Netlify preview deploy succeeded) |
|
Thanks @martzoukos for creating this PR; this is important information, for sure! I think the places you have it are good, but I am thinking we might want also need it in some even more obvious places:
Or is that too wide a net? |
tanberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martzoukos for this PR. I tweaked the wording a bit to try to make it clear that what we call composite types are same, in MongoDB, as embedded documents.
|
|
||
| <Admonition type="warning"> | ||
|
|
||
| [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types) or [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) are not supported in Prisma Studio, the Data Browser or the Query Console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types) or [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) are not supported in Prisma Studio, the Data Browser or the Query Console. | |
| [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types), known as [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) in MongoDB, are not supported in Prisma Studio, the Data Browser, or the Query Console. |
|
|
||
| <Admonition type="warning"> | ||
|
|
||
| [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types) or [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) are not supported in Prisma Studio, the Data Browser or the Query Console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types) or [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) are not supported in Prisma Studio, the Data Browser or the Query Console. | |
| [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types), known as [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) in MongoDB, are not supported in Prisma Studio, the Data Browser, or the Query Console. |
| - Management of `@unique` indexes is realized through `db push` | ||
| - [`@@id`](/reference/api-reference/prisma-schema-reference#id-1) and [auto-increment](/reference/api-reference/prisma-schema-reference#generate-auto-incrementing-integers-as-ids) are **not** supported. | ||
| - Error handling is incomplete. | ||
| - [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types) or [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) are not supported in Prisma Studio, the Data Browser or the Query Console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types) or [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) are not supported in Prisma Studio, the Data Browser or the Query Console. | |
| - [Composite types](https://www.prisma.io/docs/concepts/components/prisma-schema/data-model#defining-composite-types), known as [embedded documents](https://docs.mongodb.com/manual/core/data-model-design/#std-label-data-modeling-embedding) in MongoDB, are not supported in Prisma Studio, the Data Browser, or the Query Console. |
|
Quick note: We might actually get composite type "support" until next week in Studio, so do not spend to much more time on finding ways how to tell people that this is not supported. |
|
I think we can close this? https://prisma-company.slack.com/archives/C013RMLGE72/p1648832839575889 |
|
Yes, the change in Studio does make this notice obsolete. |
Describe this PR
We're adding a notice that Composite types are not supported in Studio, Data Browser and Query Console. If a user tries to open a model with composite types, Studio and Data Browser will crash with an error.
As such, a first disclaimer is to let people know of this behavior, before we proceed to fix or suppress the actual issues.
Changes
Added the notification:
Here's what it looks like:
