perf(Button): Replace :has(.Visual) with data-no-visuals attribute #7327
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace :has(.Visual) selectors with [data-no-visuals] attribute checks to avoid descendant DOM scans. Added documentation comments explaining acceptable :has() usage patterns. Part of #7312
🦋 Changeset detectedLatest commit: a6617a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance optimizations for Button CSS selectors to improve INP.
Changes
:has(.Visual)selectors with[data-no-visuals]attribute checksExpected INP Impact
Why this matters
Button is one of the most frequently used components. Every hover, focus, and click triggers style recalculation. The
:has(.Visual)selector was forcing descendant scans on every single button interaction. Data attribute checks are O(1).Part of the INP performance optimization effort. See #7312 for full context.