Conversation
기존 @bean 대신 @componentscan 사용하도록 변경
과제 커밋과 분리를 위해 강의 내용 완료 시점까지의 커밋 작성
VictoryPark
reviewed
Sep 22, 2021
| } | ||
|
|
||
|
|
||
| private void validate(String name) { |
There was a problem hiding this comment.
validate 를 사용하는 곳이 없는데 왜 선언하신거죠..?🥲
만약 사용하실 거라면,
Wallet 클래스에 맞는 validate 로직이어야 할 것 같습니다.
VictoryPark
reviewed
Sep 22, 2021
| public class Wallet { | ||
| private final UUID walletId; | ||
| private final UUID customerId; | ||
| private UUID voucherId; |
VictoryPark
approved these changes
Sep 22, 2021
VictoryPark
left a comment
There was a problem hiding this comment.
진환님!
전반적으로 강의로 들으신 것들을 잘 활용하여 잘 작성해주셨습니다.
한가지 말씀드리고 싶은 것은
**Operator 라고 선언하신 클래스들 메소드에 @transactional 어노테이션이 있던데,
보통 Service 레이어에서 Transaction 관리가 됩니다.
**Operator는 web 에서 controller와 같은 역할로 구현하셨더라구요.
Service 레이어로 transaction을 뺐을때,
각 Service와 Repository의 의존관계가 조금 달라질 겁니다.
그렇게 수정해서 다시 구현해보셔요!
고생하셨습니다 ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
미션 내용
(기본 과제) 바우처 관리 애플리케이션
(심화 과제) 바우처 지갑을 만들어보세요.
👩💻 요구 사항과 구현 내용
3주차 과제 피드백 구현(링크)
4주차 과제 기능구현
✅ PR 포인트