-
-
Notifications
You must be signed in to change notification settings - Fork 645
Update defaultplatform.md #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KyrietS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I added some comments requesting minor changes.
Please use --amend when you commit the fixes 🙂
|
I'm sorry to be late, but I made the PR just before leaving and I just got home again. |
KyrietS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great 👍 Now it's all good to me. I'll leave it for some time and then we'll merge your change
|
Thanks a lot for guiding me! I hope to be able to contribute again! |
|
I hope to have done verything as it should be done. |
|
Don't be afraid to challenge my ideas 😄 I will give you one more day to squash your commits. Here is what you need to do in case you're not very good at git 🙃
|
|
I followed your instructions very carefully. I'm not sure if I had to do two commits though as I added the reference to defaultplatform.md to platforms.md. I hope it's good now, for anything I will try again. Thank you for your patience.😓 |
KyrietS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Thanks for contributing to Premake's docs 🤗
What does this PR do?
This PR adds the documentation for defaultplatform as there was only the automatically generated empty one.
How does this PR change Premake's behavior?
It doesn't.
Anything else we should know?
I tested the behaviour of defaultplatform extensively only with the gmake2 as the Makefile was giving problems.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged) - Does not applyYou can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!