Skip to content

Conversation

@GiacomoMaino
Copy link
Contributor

What does this PR do?

This PR adds the documentation for defaultplatform as there was only the automatically generated empty one.

How does this PR change Premake's behavior?

It doesn't.

Anything else we should know?

I tested the behaviour of defaultplatform extensively only with the gmake2 as the Makefile was giving problems.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass - Does not apply
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged) - Does not apply
  • Follow our coding conventions - Does not apply
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I added some comments requesting minor changes.

Please use --amend when you commit the fixes 🙂

@GiacomoMaino
Copy link
Contributor Author

I'm sorry to be late, but I made the PR just before leaving and I just got home again.
It was my first time ammending a commit, so I hope to have done everything correctly.
Please, keep me posted.

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great 👍 Now it's all good to me. I'll leave it for some time and then we'll merge your change

@GiacomoMaino
Copy link
Contributor Author

Thanks a lot for guiding me! I hope to be able to contribute again!

@GiacomoMaino
Copy link
Contributor Author

I hope to have done verything as it should be done.
I thought it was bizarre but I didn't dare to ask. 😓
If I need to change anything else let me know!

@KyrietS
Copy link
Member

KyrietS commented Oct 29, 2022

Don't be afraid to challenge my ideas 😄
I can see that you've made another 3 commits. We try to minimize the number of commits if the change is small. In your case we should have one commit. So either you squash the commits on your branch into one or I will squash it doing merge, but then you won't be listed as an author of the change in our repo (it would be me, who click the merge button).

I will give you one more day to squash your commits. Here is what you need to do in case you're not very good at git 🙃

  1. Go to your repo and checkout your branch patch-1: git checkout patch-1
  2. git reset --soft master
  3. git add .
  4. git commit -m "Update defaultplatform.md"
  5. git push --force

@GiacomoMaino
Copy link
Contributor Author

I followed your instructions very carefully. I'm not sure if I had to do two commits though as I added the reference to defaultplatform.md to platforms.md.

I hope it's good now, for anything I will try again. Thank you for your patience.😓

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Thanks for contributing to Premake's docs 🤗

@KyrietS KyrietS merged commit 1046b37 into premake:master Oct 31, 2022
@GiacomoMaino GiacomoMaino deleted the patch-1 branch October 31, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants