Skip to content

Conversation

@Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Sep 7, 2022

What does this PR do?

Fix custom build for codelite when generated files which are in new/missing directory

How does this PR change Premake's behavior?

Only change Codelite generation.

Anything else we should know?

Tested in my test repository with https://github.com/Jarod42/premake-sample-projects/actions/runs/3006214377

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective, LGTM. That said, I'm not well versed in Codelite, so I'd like to leave this open so someone with more Codelite experience can take a look.

@samsinsane samsinsane merged commit 261b627 into premake:master Oct 3, 2022
@Jarod42 Jarod42 deleted the codelite_fix_missing_directory branch October 3, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants