Add custom rules for Gmake2 & Codelite #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starkos
requested changes
Oct 7, 2021
Member
starkos
left a comment
starkos
left a comment
There was a problem hiding this comment.
Thanks for digging into this! The title makes it sounds like you cracked custom rules for Gmake2 and CodeLite — 🎉 — but I'm not seeing any unit tests to back that up?
starkos
requested changes
Oct 22, 2021
Member
starkos
left a comment
starkos
left a comment
There was a problem hiding this comment.
Looking good, thanks so much for this! Just a couple of small comments inline.
starkos
changed the title
samsinsane
approved these changes
Oct 23, 2021
starkos
requested changes
Oct 27, 2021
Member
starkos
left a comment
starkos
left a comment
There was a problem hiding this comment.
Okay, looking good. Can you squash the commits and rebase against the latest main branch, and I will approve ASAP? Thanks!
- move rule code from gmake2.lua to rule.lua - Add UTs - Fix enum case - uniformise code for list. - Add support of rules for Codelite.
Contributor
Author
|
rebase and squash done. |
starkos
approved these changes
Oct 28, 2021
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How does this PR change Premake's behavior?
Handling of separator and switch in propertydefinition is coherent with msvc.
Anything else we should know?
The refacto (rule code moved from gmake to rule) is also used to add support of CustomRule for premake-ninja module
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!