Skip to content

Conversation

@noresources
Copy link
Contributor

What does this PR do?

How does this PR change Premake's behavior?

Xcode 8 and earlier will not recognize SYSTEM_HEADER_SEARCH_PATHS setting

Anything else we should know?

As discussed in #1456, a Xcode target version may be added later to support the previous behaviour

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

Renaud Guillard added 2 commits October 23, 2020 09:58
* Merge libdirs and syslibdirs to LIBRARY_SEARCH_PATHS setting
* Add test
* Use the new Xcode 9+ setting SYSTEM_HEADER_SEARCH_PATHS settings instead of HEADER_SEARCH_PATHS
* Update test
Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, but I'm not doing any Xcode work these days.

@samsinsane samsinsane merged commit 82e5036 into premake:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headers include paths are written to "User Header Search Paths" instead of "Header Search Paths" in Xcode

3 participants