Skip to content

systemtests: archive fieldcompare diff files on failure #742

Open
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
AdityaGupta716:systemtests/archive-diff-files
Open

systemtests: archive fieldcompare diff files on failure #742
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
AdityaGupta716:systemtests/archive-diff-files

Conversation

@AdityaGupta716
Copy link

@AdityaGupta716 AdityaGupta716 commented Mar 7, 2026

What this PR does

When fieldcompare fails, the diff VTK files it generates (via the --diff flag already present in the compose template) are now copied to a diff-results/ folder inside the system test directory. This means they get included in the CI artifact and can be downloaded for visual inspection of exactly where results diverged.

Closes #441

Changes

  • Added __archive_diff_files() to Systemtest.py — scans precice-exports/ for any *diff*.vtu, *diff*.vtk, or *diff*.vtp files after a fieldcompare failure and copies them to diff-results/
  • Called only when fieldcompare_result.exit_code != 0 — no unnecessary copies on passing runs
  • Updated README.md to mention that diff files are available in diff-results/ for ParaView inspection

Notes

The --diff flag is already passed to fieldcompare in docker-compose.field_compare.template.yaml, so the diff files are already being generated — they just weren't being saved anywhere accessible until now.

Checklist

  • I added a summary of any user-facing changes in changelog-entries/742.md
  • I will remember to squash-and-merge with a useful summary

@AdityaGupta716 AdityaGupta716 force-pushed the systemtests/archive-diff-files branch from 345ddbd to 065c8b2 Compare March 7, 2026 04:14
@AdityaGupta716 AdityaGupta716 changed the title systemtests: archive fieldcompare diff files on failure (#441) systemtests: archive fieldcompare diff files on failure Mar 7, 2026
@AdityaGupta716
Copy link
Author

hi @MakisH, plz review! The --diff flag was already being passed to fieldcompare but the generated diff files were never saved anywhere accessible — this copies them to diff-results/ on failure so they show up in the CI artifact and can be opened in ParaView to see exactly where results diverged.

@AdityaGupta716 AdityaGupta716 force-pushed the systemtests/archive-diff-files branch from b804f22 to 6b4f009 Compare March 7, 2026 04:25
@AdityaGupta716 AdityaGupta716 force-pushed the systemtests/archive-diff-files branch from cdffa12 to 35bceea Compare March 7, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archive diff files in the reports

1 participant