systemtests: archive fieldcompare diff files on failure #742
Open
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
Open
systemtests: archive fieldcompare diff files on failure #742AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
Conversation
345ddbd to
065c8b2
Compare
Author
|
hi @MakisH, plz review! The |
b804f22 to
6b4f009
Compare
cdffa12 to
35bceea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When fieldcompare fails, the diff VTK files it generates (via the
--diffflag already present in the compose template) are now copied to adiff-results/folder inside the system test directory. This means they get included in the CI artifact and can be downloaded for visual inspection of exactly where results diverged.Closes #441
Changes
__archive_diff_files()toSystemtest.py— scansprecice-exports/for any*diff*.vtu,*diff*.vtk, or*diff*.vtpfiles after a fieldcompare failure and copies them todiff-results/fieldcompare_result.exit_code != 0— no unnecessary copies on passing runsREADME.mdto mention that diff files are available indiff-results/for ParaView inspectionNotes
The
--diffflag is already passed to fieldcompare indocker-compose.field_compare.template.yaml, so the diff files are already being generated — they just weren't being saved anywhere accessible until now.Checklist
changelog-entries/742.md