Archive fieldcompare diff files in fieldcompare-diffs/ (fixes #441)#740
Open
PranjalManhgaye wants to merge 1 commit intoprecice:developfrom
Open
Archive fieldcompare diff files in fieldcompare-diffs/ (fixes #441)#740PranjalManhgaye wants to merge 1 commit intoprecice:developfrom
PranjalManhgaye wants to merge 1 commit intoprecice:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #441: archive fieldcompare diff VTK files so they are easy to find in CI artifacts.
Changes
tools/tests/systemtests/Systemtest.py: After each fieldcompare run, copy any diff_* and _diff. files from precice-exports/ into a new fieldcompare-diffs/ folder in the same run directory. No change to existing behaviour; diff files stay in precice-exports/ and are also collected in fieldcompare-diffs/.
tools/tests/README.md: Note that diff files are copied into fieldcompare-diffs/ for inspection (e.g. in ParaView) when debugging comparison failures.
Checklist