chore(package): add typescript declarations (types)
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teabyii
changed the title
voischev
approved these changes
Dec 19, 2017
Scrum
requested review from
eugenefedotov
and removed request for
Scrum and
mrmlnc
Scrum
changed the title
Member
|
@eugenefedotov approve ? |
michael-ciniawsky
requested changes
Mar 20, 2018
Member
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
Could you add them to https://github.com/DefinitelyTyped/DefinitelyTyped instead please, it's the recommended way advocated by the typescript team
michael-ciniawsky
changed the title
types)
|
@michael-ciniawsky it's the recommended way when these are types added post-factum by the community. Does this mean that you don't wish to maintain these types in-repo in future versions? |
0ctothorp
reviewed
Oct 9, 2019
| singleTags?: string[], | ||
| closingSingleTag?: string | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| type TreeNode = | |
| | { | |
| tag: string; | |
| attrs?: Record<string, string>; | |
| content?: Tree; | |
| } | |
| | string; | |
| type Tree = TreeNode[]; |
| closingSingleTag?: string | ||
| } | ||
|
|
||
| declare function postHTMLRender(tree: any, options?: Options): string; |
Contributor
There was a problem hiding this comment.
I think we can be more precise with the tree type. I suggested a change above with the type Tree.
Member
|
@0ctothorp Hi, any of your contributions is very important to us. Yes, PR is old and maybe you can offer the best option :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.