Update code to use REST API instead of CSOM to solve the issue with root site. Closes #5249.

[reshmee011]

Update code to use REST API instead of CSOM to solve the issue with root site. Closes #5249.

Type

• Bug Fix

Related Issues?

Fixes #5249.

[gautamdsheth]

Hey @reshmee011 , not sure if we can merge it in this release. It is a breaking change as far as I can see. We need to return a CSOM object here. Maybe we can do it in next major release like v4 ?

[reshmee011]

The cmdlet behaves the same as it did when we combined CSOM and REST, just with one fewer API call now. The only change is that the REST endpoint no longer exposes the external flag, but that doesn’t affect functionality I can still add external links like http://www.google.com without it and we could mark external parameter as deprecated.

[gautamdsheth]

It is a breaking change because the output type has changed here.

1. Currently implementation outputs Microsoft.SharePoint.Client.NavigationNode whereas this PR outputs Model.SharePoint.NavigationNode. This change should only be done a major release.

2. The IsExternal parameter should be deprecated if we dont use it.

3. We also need to check if this also works on old classic SP sites, not just modern sites.

[reshmee011]

@gautamdsheth : Good points ! Agree let's postpone it for next release.