Skip to content

[tenant-namespace-operator] Upgraded to Operator SDK v1.4.0#23

Merged
plnordquist-pnnl merged 2 commits intopnnl-miscscripts:masterfrom
plnordquist-pnnl:tno-1.4
Oct 26, 2023
Merged

[tenant-namespace-operator] Upgraded to Operator SDK v1.4.0#23
plnordquist-pnnl merged 2 commits intopnnl-miscscripts:masterfrom
plnordquist-pnnl:tno-1.4

Conversation

@plnordquist-pnnl
Copy link

  • Migrated to new directory structure
  • Upgraded crds to apiextensions v1
  • Added probes to chart
  • Updated entrypoint for new docker image
  • Fixed references to meta in ansible role

@plnordquist-pnnl plnordquist-pnnl marked this pull request as draft February 11, 2021 03:34
@plnordquist-pnnl
Copy link
Author

Marked as Draft until I can test upgrading from the older CRD definition and older deployment. Tested and works with new resources.

@plnordquist-pnnl plnordquist-pnnl marked this pull request as ready for review February 11, 2021 19:53
@plnordquist-pnnl
Copy link
Author

Tested upgrading from older CRDs and chart version. Ansible reported zero changes when upgrading the chart. I think the CRD validation changes could complain about missing data if we put anything outside of spec or status but I think that would be an error anyways on our part.

Migrated to new directory structure
Upgraded crds to apiextensions v1
Added probes to chart
Updated entrypoint for new docker image
Fixed references to meta in ansible role
Bump tenant-namespace-operator version
@plnordquist-pnnl plnordquist-pnnl marked this pull request as draft October 25, 2023 19:09
@plnordquist-pnnl plnordquist-pnnl marked this pull request as ready for review October 26, 2023 22:00
@plnordquist-pnnl
Copy link
Author

I've rebased this and re-tested after the rebase. I didn't find any issues with upgrades or new resources after deploying the new operator. The CRD concerns above were already addressed when the CRDs were merged outside of this PR to upgrade them to apiextensions.k8s.io/v1.

Copy link

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@plnordquist-pnnl plnordquist-pnnl merged commit 8d55c99 into pnnl-miscscripts:master Oct 26, 2023
@plnordquist-pnnl plnordquist-pnnl deleted the tno-1.4 branch October 26, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants