Emf support for save as #1306
Merged
Emf support for save as #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @michaelbabyn , lgtm (💃) as soon as tests are passing |
Contributor
|
Huh, looks like there was still one failure on a throttling response for Python 2.7. |
michaelbabyn
force-pushed
the
emf-support-for-save-as
branch
from
3c8500b to
d3ea11f
Compare
Contributor
Author
|
I figured out that the throttling failure was because CircleCI was building plotly against version 3.3.0, which was the most recent version of plotly.py that I had merged into my fork. Updating my branch fixed that issue... |
Contributor
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
plotly.plotly.image.save_asto support theemffile type. The tests pass on theadd_emf_backendbranch of streambed in this PR.cc @bpostlethwaite