Skip to content

line and area on mapbox #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mahdis-z wants to merge 2 commits into from
Closed

line and area on mapbox #120

Mahdis-z wants to merge 2 commits into from

Conversation

@Mahdis-z
Copy link
Contributor

@Mahdis-z Mahdis-z commented Sep 11, 2019

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

nicolaskruchten
nicolaskruchten suggested changes Sep 18, 2019
View reviewed changes
nicolaskruchten
nicolaskruchten reviewed Sep 18, 2019
View reviewed changes
nicolaskruchten
nicolaskruchten reviewed Sep 18, 2019
View reviewed changes
python/Mapbox-area.md
fig.show()
```

### Use the Coresponding Geojson
Copy link
Contributor

@nicolaskruchten nicolaskruchten Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Rs in corresponding

@Mahdis-z Mahdis-z removed the request for review from michaelbabyn September 19, 2019 19:45
@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Sep 20, 2019

what's the difference between this PR and #125 ?

@Mahdis-z
Copy link
Contributor Author

Mahdis-z commented Sep 20, 2019

what's the difference between this PR and #125 ?

area-line is the branch name for js docs as well. So switching to the area-line branch I couldn't see the changes in local repo! I'll close this pr once made the revisions.

@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Sep 25, 2019

replaced with #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicolaskruchten nicolaskruchten nicolaskruchten requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mahdis-z @nicolaskruchten