Fix bug which prevented multiple outputs in callbacks returning Dash components in R #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a minor modification to the way Dash for R's
_dash-update-componenthandler resolves multiple outputs in callbacks which return one or more Dash components. This bug was discovered accidentally while fixing another bug in the Dash for R docs.Previously,
updatable_outputsimplicitly assumedoutput_value's elements were members of only one class, since the specified return type ofvapplywascharacter(1):dashR/R/dash.R
Lines 477 to 478 in b3be88d
This was insufficiently robust, since valid return values from Dash callbacks can be objects in R which are members of more than one class.
As an example, if a callback returns
list(htmlDiv(), ""), the class membership of its elements would beThe original definition of
updatable_outputswould essentially attemptvapply(list(htmlDiv(), ""), class, character(1))which produces the cryptic errorBy rewriting the original line as
class membership is inspected more flexibly, and a logical result is returned in the
vapplystep instead of acharactervector of class names.