Component as props by T4rk1n · Pull Request #1965 · plotly/dash

T4rk1n · 2022-03-11T21:48:08Z

Add component as prop support.

Contributor Checklist

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md
If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
- this GitHub #PR number updates the dash docs
- here is the show and tell thread in Plotly Dash community

components/dash-core-components/src/components/Checklist.react.js

@plotly/dash-test-components/src/components/ComponentAsProp.js

dash/development/base_component.py

dash/dash-renderer/src/actions/utils.js

# Conflicts: # dash/development/base_component.py

…andle children props.

dash/development/base_component.py

tests/unit/development/test_collect_nodes.py

alexcjohnson · 2022-06-01T22:28:27Z

dash/development/base_component.py


+    @classmethod
+    def _get_base_nodes(cls):
+        if not cls._base_nodes:


if a component has lots of props but none of them accept components, will we run this iteration every time one of them is instantiated? If so, can we avoid that? Moving + ["children"] in here would be one way perhaps?

oh sorry, it's only iterating over _children_props - so the problem only comes if there are lots of nested props and no base props. Still would be best to avoid.

Let's move that to the generator.

Looks great! Seems like the way you implemented this is compatible with the old generated components, how hard would it be to add a test to explicitly verify that? ie include a component in the tests that doesn't auto-generate but instead uses the old generator output?

Added a legacy test from the old standard component output.

alexcjohnson

Looks great! Add a changelog entry and consider my minor perf comment and I think we're ready to go! 💃

T4rk1n requested a review from alexcjohnson as a code owner March 11, 2022 21:48

T4rk1n force-pushed the component-as-props branch from 652f6e5 to eab4b27 Compare March 14, 2022 14:00

alexcjohnson mentioned this pull request Apr 7, 2022

Component as props support. plotly/dash-renderer#92

Closed

T4rk1n force-pushed the component-as-props branch 2 times, most recently from 8f4373f to 3905100 Compare April 20, 2022 18:23

alexcjohnson mentioned this pull request Apr 22, 2022

Skip check on whether a component is passed as a non-children property. #1916

Closed

T4rk1n added 11 commits April 25, 2022 14:01

Add test component as prop.

9eb975a

Add component as prop support

3c91fd0

Add childrenProps to components json only if there is any.

7f1f5eb

Remove test component not children.

be3fea4

Handle components in list.

60367ec

Add support for component in dictionaries props.

253f03a

Lint fix.

56bd57a

Support components in list of dictionary.

e2cf8dc

Add checklist label support for components.

cf7e6b3

Add RadioItems label support for components.

f8a2f3e

Add dropdown label support for components.

dce32fd

T4rk1n force-pushed the component-as-props branch from b3f688d to dce32fd Compare April 25, 2022 18:09