Component nested artifacts + Test #1203
Conversation
- fix lint errors
| if not os.path.exists(target_dirname): | ||
| os.makedirs(target_dirname) | ||
|
|
||
| shutil.copy(os.path.join(rel_dirname, filename), target_dirname) |
There was a problem hiding this comment.
So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)
| dash_duo.start_server(app) | ||
|
|
||
| assert dash_duo.wait_for_element("#standard").text == "Standard" | ||
| assert dash_duo.wait_for_element("#nested").text == "Nested" |
There was a problem hiding this comment.
Check if both dummy standard and nested components load correctly
| "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC", | ||
| "private::lint.renderer": "cd dash-renderer && npm run lint", | ||
| "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .", | ||
| "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .", |
There was a problem hiding this comment.
Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?
There was a problem hiding this comment.
No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆
Based on the community PR #1125: