-
-
Notifications
You must be signed in to change notification settings - Fork 49
Added data-* and aria-* attributes #40
Conversation
scripts/generate-components.js
Outdated
| * A wild-card data-* attribute | ||
| */ | ||
| 'data-*': PropTypes.string, | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add aria-* too
|
Hi @rmarren1, I've also not been able to use the This attribute is required for use with |
|
Are there any elements where |
|
Can be applied to any element: Other documents of interest:
Hard-coding this seems sensible if that is already being done for For background, I bumped into this because of using Bootstrap which requires |
|
added |
|
Thanks! |
|
@rmarren1 - I'm 👍 with these changes. Is there anything else that you would like to add? Otherwise, I will merge and release. |
|
I'm good with it, go ahead! |
plotly/dash#237