Conversation
➕ ⚡ add prop type check in components
|
@plotly/dash-core a quick glimpse of |
👍 . I just found this data in a structured format here: https://github.com/iandevlin/html-attributes, seems like we could use that in our component generation script. |
|
also might need to evaluate how we deal with booleans too. I think we should accept them and coerce to not sure what to do about https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes#Boolean_Attributes:
However, I believe React will just ignore it now: https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html & https://reactjs.org/docs/jsx-in-depth.html#props-default-to-true |
|
the |
|
@byronz can we close this PR (and issue #107), since plotly/dash-renderer#100 does this for all components? |

@alexcjohnson @chriddyp I have a concern about the current state of our defined PropTypes,
one example is
draggable: PropTypes.string, but per HTML reference it's an enumerated attribute with {true, false, auto}.we don't have another useful attribute
inputmode, which is also an enumerated list, and it's a good demo case for <textarea> andthis fixes #107